RE: [PHP-DEV] Patch for opcode caches

Hi Marcus, > -----Original Message----- > From: Marcus Boerger [mailto:helly@php.net] > Sent: Thursday, March 13, 2008 9:27 PM > To: Dmitry Stogov > Cc: Andi Gutmans; Stas Malyshev; phpxcache; internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode caches > > > Hello Dmitry, > > Monday, March 10, 2008, 1:48:05 PM, you wrote: > > > Hi Marcus, > > >> > -----Original Message----- > >> > From: Marcus Boerger [mailto:helly@php.net] > >> > Sent: Sunday, March 09, 2008 3:00 PM > >> > To: Dmitry Stogov > >> > Cc: Derick Rethans; internals Mailing List; Andi Gutmans; Stas > >> > Malyshev; phpxcache > >> > Subject: Re: [PHP-DEV] Patch for opcode caches > >> > > >> > Hello Dmitry, > >> > > >> > please don't apply. The patch looks rather rough and > untested (see > >> > below). > > > It was tested at least with Zend products and xcache. > > Good, I am just worried that we introduce different behavior. > We should just have one execution mode. Your change is better > now having a more detailed view on what it does. But I think > we should not have the old model as well. Removing early-binding at all might be a subject for PHP6, however in PHP_5_3 we even keep ze1_compatibility_mode. I'm not able to remove it. [skiped] > > 5) I'll recheck the -e option. Probably I missied something there. > > I did not see -e in the list of allowed flags. So it cannot work. Then I don't understand you last comments about the patch. Thanks. Dmitry.