Re: [PATCH] Bug 43477 - Unicode error mode ignored
| From: | Andrei Zmievski | Date: | Mon, 24 Mar 2008 16:55:37 +0000 |
| Subject: | Re: [PATCH] Bug 43477 - Unicode error mode ignored | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36437@lists.php.net to get a copy of this message | ||
Where is the patch?
Geoffrey Sneddon wrote:
On 21 Mar 2008, at 12:09, Antony Dovgal wrote:On 03/18/2008 06:51 AM, Stephen Bach wrote:Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug should be closed. -- Geoffrey Sneddon <http://gsnedders.com/>Attached is a simple proposed patch that fixes Bug 43477. Basically, the code that set the error mode of the ICU converter was giving it an instruction (the context parameter) to only skip or substitute if the code point was not represented in the new encoding. However, it still was returning an error for illegal sequences. The test suite returns the same results with or without the patch. Test also attached.Patch committed, thanks.