Re: [PATCH] Bug 43477 - Unicode error mode ignored
| From: | Andrei Zmievski | Date: | Thu, 20 Mar 2008 20:32:49 +0000 |
| Subject: | Re: [PATCH] Bug 43477 - Unicode error mode ignored | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36226@lists.php.net to get a copy of this message | ||
Okay. I'm fine with the patch.
Stephen Bach wrote:
Sorry for the ambiguity. Allow me to clarify: I meant that U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST should work the same as the other error modes. Otherwise, what's the point of having them? -Stephen On Tuesday 18 March 2008 06:02:36 pm Geoffrey wrote:On 18 Mar 2008, at 19:37, Stephen Bach wrote:Shouldn't U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST work the same way?I guess: U_CONV_ERROR_SKIP is just U_CONV_ERROR_SUBST with the substitution string as nothing, though I expect slight speed gains could be made by keeping them separate (due to no attempt to even add anything after coming across an invalid sequence — though the speed gains will be very slight). -- Geoffrey Sneddon <http://gsnedders.com/>