Re: Inclusion of PHP LiteSpeed SAPI in the standard PHP distribution?
| From: | George Wang | Date: | Tue, 08 Apr 2008 14:12:40 +0000 |
| Subject: | Re: Inclusion of PHP LiteSpeed SAPI in the standard PHP distribution? | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36871@lists.php.net to get a copy of this message | ||
Hi Johannes,
Well, the idea is that all PHP-specific code is licensed under the same license terms. PCRE and GD are external libraries which live outside PHP's context and which are simply bundled. That's why the clear preference there is PHP License. I have updated the license to have it dual-licensed under PHP and BSD licenses.
Additionally it would nice to follow the PHP coding standards. Like always having { } after an if statement. This helps PHP developers who might (possibly) help fixing reported (simple) bugs or apply API changes. The code has been updated to follow the PHP coding standards in regard of using { }, if there is any other issue, please let me know, I will fix it ASAP.
Other than that we, again, have our problem about what's the best way to "bundle" something from pecl. I guess the symlink on the CVS server is the best option we currently have... Either a symlink or moving the directory physically to where other SAPI code are should work. I can check in the code to a different location if need.Please let me know if anything I can help. :-) Thanks, George