Re: [PATCH] Scanner fixes and tweaks

Hello Matt, Thursday, April 10, 2008, 3:50:41 PM, you wrote: > Hi Scott, > I noticed that Nuno changed yyless() to be like flex after your commit (not > in HEAD? I considered that, but figured you guys wanted it different :-)), > but now the heredoc end part is wrong again (hehe), and I see Tony reported > the broken tests... Attached patch puts it back to pre-re2c state. Also > remembered a useless "case EOF;" to remove in zendlex() to match HEAD's > (added at end of '05 (v1.647.2.18) for bug #35382, later fixed in the > scanner; doesn't look like it ever did much anyway). > BTW, maybe you could change the name in that 5.2 NEWS entry to just "Matt"? > No big deal, but that's what it's been other than the first few entries. :-) We use short names only for people with a php.net account. Thanks for the fixes anyway. > Thanks, > Matt > ----- Original Message ----- > From: "Scott MacVicar" > Sent: Tuesday, April 08, 2008 >> Thanks Matt, >> >> I'll review these and merge them in with my other scanner fixes. >> >> Scott Best regards, Marcus