Re: [PATCH] Scanner fixes and tweaks
| From: | Philip Olson | Date: | Thu, 10 Apr 2008 17:14:39 +0000 |
| Subject: | Re: [PATCH] Scanner fixes and tweaks | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-36922@lists.php.net to get a copy of this message | ||
On 10 Apr 2008, at 09:48, Marcus Boerger wrote:
Hello Matt, Thursday, April 10, 2008, 3:50:41 PM, you wrote:Hello Matt- Just in case you've not seen this page yet, please go here and apply :) http://php.net/cvs-php.php Regards, PhilipHi Scott,I noticed that Nuno changed yyless() to be like flex after your commit (not in HEAD? I considered that, but figured you guys wanted it different :-)), but now the heredoc end part is wrong again (hehe), and I see Tony reported the broken tests... Attached patch puts it back to pre-re2c state. Also remembered a useless "case EOF;" to remove in zendlex() to match HEAD's (added at end of '05 (v1.647.2.18) for bug #35382, later fixed in the scanner; doesn't look like it ever did much anyway).BTW, maybe you could change the name in that 5.2 NEWS entry to just "Matt"? No big deal, but that's what it's been other than the first few entries. :-)We use short names only for people with a php.net account.