Re: intl naming
| From: | Pierre Joye | Date: | Wed, 16 Apr 2008 13:30:47 +0000 |
| Subject: | Re: intl naming | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-37036@lists.php.net to get a copy of this message | ||
On Wed, Apr 16, 2008 at 3:21 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> Please find a patch as attachment, fixing some bad #ifdef. This test
> should be in the main intl header, imo.
Forgot to attach a second for config.w32, to nicely detect the
required libraries.
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org
Index: config.w32 =================================================================== RCS file: /repository/pecl/intl/config.w32,v retrieving revision 1.1.2.10 diff -u -r1.1.2.10 config.w32 --- config.w32 4 Apr 2008 17:15:02 -0000 1.1.2.10 +++ config.w32 10 Apr 2008 20:44:51 -0000 @@ -63,6 +63,12 @@ dateformat_parse.c \ dateformat_data.c \ ", "intl"); + CHECK_LIB("icudt.lib", "intl"); + CHECK_LIB("icuin.lib", "intl"); + CHECK_LIB("icuio.lib", "intl"); + CHECK_LIB("icule.lib", "intl"); + CHECK_LIB("iculx.lib", "intl"); + ADD_FLAG("LIBS_INTL", "icudt.lib icuin.lib icuio.lib icule.lib iculx.lib"); // if int32_t and uint32_t types are made available in PHP, uncomment next line // ADD_FLAG("CFLAGS_INTL", "/D U_HAVE_INT32_T /D U_HAVE_UINT32_T");
Index: config.w32 =================================================================== RCS file: /repository/pecl/intl/config.w32,v retrieving revision 1.1.2.10 diff -u -r1.1.2.10 config.w32 --- config.w32 4 Apr 2008 17:15:02 -0000 1.1.2.10 +++ config.w32 10 Apr 2008 20:44:51 -0000 @@ -63,6 +63,12 @@ dateformat_parse.c \ dateformat_data.c \ ", "intl"); + CHECK_LIB("icudt.lib", "intl"); + CHECK_LIB("icuin.lib", "intl"); + CHECK_LIB("icuio.lib", "intl"); + CHECK_LIB("icule.lib", "intl"); + CHECK_LIB("iculx.lib", "intl"); + ADD_FLAG("LIBS_INTL", "icudt.lib icuin.lib icuio.lib icule.lib iculx.lib"); // if int32_t and uint32_t types are made available in PHP, uncomment next line // ADD_FLAG("CFLAGS_INTL", "/D U_HAVE_INT32_T /D U_HAVE_UINT32_T");