Re: new PostgreSQL API (was Re: [PHP-DEV] CVS Account Request)

Hello Tatsuo, I never saw an update on this patch, is there any? Also did you ever apply for an account? Please do the following: 1) Change your patch with Tony's comment in mind (don't add lo_import_with_oid) 2) Resend the updated patch in unified format (diff -u) 3) Provide tests 4) Apply for an account using the web form marcus Wednesday, April 23, 2008, 10:31:59 AM, you wrote: >> On 17.04.2008 18:50, Tatsuo Ishii wrote: >> > Here are the patches against 5.2 HEAD. >> >> First of all, please use diff -u, not just >> diff - unified diffs are much more readable. > Ok. I'll do it next time. >> > Modified API's are: >> > >> > 1) pg_lo_create now accepts an optional parameter (large object >> > id). This corresponds to lo_create() which is new in PostgreSQL 8.1. >> > >> > 2) new API: pg_lo_import_with_oid. Same as pg_lo_import except that it >> > accepts large object id. This corresponds to lo_import_with_oid() >> > which is new in PostgreSQL 8.4 (current). >> >> Is there a real need for a new function? >> Can't we modify pg_lo_import() to accept one more argument? > There's no techinical reason to add lo_import_with_oid(). I just > wanted to directly map the PostgreSQL API to PHP's API. If integrating > to pg_lo_import() is the PHP's way, I would be happy to update my > patches. > -- > Tatsuo Ishii > SRA OSS, Inc. Japan Best regards, Marcus