I can add this to PHPT - it uses a timeout based on reading the open proc.
That's what the current run-tests does too. The problem is it isn't reliable cross-platform - we don't have any control over the select() function used by stream_select() except under Windows, where it doesn't work (I'm looking into that but can't see why).
The only problem is that it is currently treated as an error. I could maybe add a new reporting level of timeout, though I do like the idea of having some sort of meta-data to conditionally skip tests.
Maybe a better solution is to add an --exclude <pattern> and ask people to either place potentially slow tests in tests/slow/, or name then <test case>.slow.phpt? Being able to exclude a pattern of test names definitely has more use than just setting a timeout.
So what was wrong with the simple skipif and env var approach again? If you're going to mark a test to get run-tests to respond to it, it doesn't make a lot of difference whether you mark that test by its name or with a skipif line. The only difference is an untidy CVS directory.
I think the naming thing would be a better idea for something that's just starting out. It's a less good idea for a test suite that already exists IMHO.
- Steph
Thoughts?
-T
-- PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php