Re: [PATCH] make it possible to skip very slow tests
| From: | Travis Swicegood | Date: | Thu, 19 Jun 2008 15:05:54 +0000 |
| Subject: | Re: [PATCH] make it possible to skip very slow tests | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-38407@lists.php.net to get a copy of this message | ||
On Jun 19, 2008, at 9:03 AM, Steph Fox wrote:
The only problem with that is everything you add I've got to add to my GSoC project so PHPT :-)There's nothing wrong with that approach. I'm trying to find something that addresses the problem (i.e., "how can I not run tests that are going to take a long time to run?"), while providing enough flexibility to answer other problems (i.e., "how can I skip X tests that I don't care about?"). If there's a way to address the problem without making it so specific, I'm all for it.I mostly agree - I'm just looking at 'here and now' rather than 'when the nice new test suite stuff is done'. 'Here and now', there isn't a reliable way to set this up and skipif looks like the cleanest option.
That might not be a bad idea.I think the long-term goal should be the ability to "force skip" files based on an --exclude parameter, an ini conf file (looks for --ini-file <file> or <cwd>/tests.ini), and an ENV variable. The first and last would just be separated by the PATH_SEPARATOR for regex patterns. In addition, we can definitely make the time-out something that's settable via the command line and conf, but as you noted in your next email, that is a separate issue. I've created a few tickets on these so we can make sure to track these issues: * add exclude: http://phpt.info/ticket/69 * add timeout: http://phpt.info/ticket/70 -T