Re: New flame

Hello Marcus, > > > The script encoding is specified by a couple of different ways. > > > (1) mbstinrg.script_encoding in php.ini > > (2) declare(encopding="Shift_JIS") on each PHP script > > -> multibyte_encoding_001.phpt > > (3) BOM in Unicode script > > -> multibyte_encoding_00[23].phpt > > (4) auto detection based on mbstring.language,mbstring.detect_order > > > The test scripts are already existing for (2),(3), but nothing for > > (1),(4). > > > I already confirmed my patch for PHP 5.3 is working for (1),(2) > > for Shift_JIS encoding. But, I didn't confirmed yet for Unicode BOM > > and other encodings. > > Could you put your confirmation of (1) into a test? And is there any > detection functionality missing to write those tests? A test script 'ext/mbstring/tests/zend-multibyte.phpt' is already existing since PHP 4.3, but, I think it should be better put into Zend/tests/multibyte/ I commited multibyte_encoding_00[45].phpt based on zend-multibyte.phpt into Zend/tests/multibyte/ The encoding detection is based on, 1. mbstring.script_encoding in php.ini 2. declare(encoding=xxxx) in the script 3. BOM in Unicode (UTF-8, UTF-16) All of these are alrady covered by the current test scrpts. Rui -- Rui Hirokawa <rui_hirokawa@ybb.ne.jp>