Re: Apache builds

Steph, Steph Fox wrote:

Hi Scott, thanks,

John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3

Ahhhhhhhhhhh it was 2 years ago in 5_2 branch.

I've not yet had time to see if there is a way to get a length of content from a previous brigade in Apache. We may just need to buffer the result and then call it? I'm unsure at the moment.

Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API?

Also I dont think the apache filter SAPI is in use by anyone, but I could be wrong here.

I suppose the chances of throwing it out are zero...

I think we can actually just add an fsizer function and use apr_brigade_length(pbb->bb); That should give us the length of all the data in the bucket brigade, not tested as I'm not even sure about how to go about doing so. I'll commit a patch later today to 5.3 and then merge all these missed changes to HEAD.

Cheers, - Steph

Scott