Re: Apache builds

From:	Scott MacVicar	Date:	Fri, 18 Jul 2008 13:08:43 +0000
Subject:	Re: Apache builds
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-39090@lists.php.net to get a copy of this message

I've committed a fix now and it compiles correctly, I also removed the two warnings. Scott Steph Fox wrote:

Scott,
Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API?
I think we can actually just add an fsizer function and use apr_brigade_length(pbb->bb);
I think that's what 'rewriting php_apache_fteller_stream() means ;) Why move it from pbb->total_len?
That should give us the length of all the data in the bucket brigade, not tested as I'm not even sure about how to go about doing so. I'll commit a patch later today to 5.3 and then merge all these missed changes to HEAD.
Cool, - Steph