Re: cvs: php-src /ext/session session.c /ext/session/tests session_decode_variation3.phpt session_encode_variation3.phpt
session_encode_variation4.phpt session_encode_variation5.phpt session_encode_variation7.phpt session_encode_variation8.phpt
| From: | Lukas Kahwe Smith | Date: | Wed, 06 Aug 2008 07:20:27 +0000 |
| Subject: | Re: cvs: php-src /ext/session session.c /ext/session/tests session_decode_variation3.phpt session_encode_variation3.phpt session_encode_variation4.phpt session_encode_variation5.phpt session_encode_variation7.phpt session_encode_variation8.phpt |
||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39690@lists.php.net to get a copy of this message | ||
On 06.08.2008, at 07:34, Jani Taskinen wrote:
jani Wed Aug 6 05:34:55 2008 UTC
Modified files:
/php-src/ext/session session.c
/php-src/ext/session/tests session_decode_variation3.phpt
session_encode_variation3.phpt
session_encode_variation4.phpt
session_encode_variation5.phpt
session_encode_variation7.phpt
session_encode_variation8.phpt
Log:
- Fixed some inconsistencies with the behaviour of sessions. Changed session_start() to return false when session start fails.
I presume your MFH commit brought this change to 5.3 as well?
I guess returning false is the reasonable expected behavior and so I would chalk it up as a bug fix and not as a BC break. But it would be good to get this kind of stuff noted on the 5.3 doc scratchpad [1]
regards,
Lukas Kahwe Smith
mls@pooteeweet.org
[1] http://wiki.php.net/doc/scratchpad/upgrade/53