Re: cvs: php-src /ext/session session.c /ext/session/tests session_decode_variation3.phpt session_encode_variation3.phpt
session_encode_variation4.phpt session_encode_variation5.phpt session_encode_variation7.phpt session_encode_variation8.phpt

Lukas Kahwe Smith kirjoitti:

On 06.08.2008, at 07:34, Jani Taskinen wrote:

jani        Wed Aug  6 05:34:55 2008 UTC

Modified files:

   /php-src/ext/session    session.c
   /php-src/ext/session/tests    session_decode_variation3.phpt
                                 session_encode_variation3.phpt
                                 session_encode_variation4.phpt
                                 session_encode_variation5.phpt
                                 session_encode_variation7.phpt
                                 session_encode_variation8.phpt

Log: - Fixed some inconsistencies with the behaviour of sessions. Changed session_start() to return false when session start fails.

I presume your MFH commit brought this change to 5.3 as well?

Of course, among other things people did not bother merging before. I think I mentioned the hash support in the PHP_5_3 commit with [DOC] ?

I guess returning false is the reasonable expected behavior and so I would chalk it up as a bug fix and not as a BC break. But it would be good to get this kind of stuff noted on the 5.3 doc scratchpad [1]

I would add it but I can't save the page..? --Jani