Re: include bug in 5.3

Hi Dmitry On 8.8.2008 17:52 Uhr, Dmitry Stogov wrote:

Hi, The attached patch is going to fix the problem.

Works also on my OS X 10.4 box now. Thanks a lot for the effort (and if it brings a performance boost, even better :) ) chregu

It implements its own realpath() function, so we won't depend on system anymore. It also improve realpath cache usage by caching intermediate results. I tested it on Linux and Windows only and it seems to work without problems. It breaks one test related to clearstatcache() function, but this break is expected. Could you please test it. Does it really fix the bug on FreeBSD? Thanks. Dmitry. Hannes Magnusson wrote:

On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc <arnaud.lb@gmail.com> wrote:

virtual_file_ex() assumes that realpath() returns NULL when the file does not exists. But BSD's realpath() will not return NULL if all components *but the last* exist. So realpath(/foo/bar) will return /foo/bar even if bar does not exists.

And that behavior is intended, but is sadly overwritten in ZTS :( -Hannes

-- New Office Zurich Opening: http://liip.to/party -- Liip AG // Feldstrasse 133 // CH-8004 Zurich Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 www.liip.ch // blog.liip.ch // GnuPG 0x5CE1DECB