Re: include bug in 5.3
| From: | Dmitry Stogov | Date: | Sat, 09 Aug 2008 15:28:07 +0000 |
| Subject: | Re: include bug in 5.3 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39797@lists.php.net to get a copy of this message | ||
The improved patch fixes all the issues I found during testing.
However I wasn't able to test it on NETWARE and on Solaris with relative
paths.
Please test it as much as possible.
I'm going to commit it on Tuesday in case of no objections.
Thanks. Dmitry.
Rasmus Lerdorf wrote:
> Rasmus Lerdorf wrote:
>> Dmitry Stogov wrote:
>>> Hi,
>>>
>>> The attached patch is going to fix the problem.
>>> It implements its own realpath() function, so we won't depend on system
>>> anymore. It also improve realpath cache usage by caching intermediate
>>> results.
>>
>> Very nice. The intermediate caching is going to drastically reduce the
>> amount of memory we need for the cache. I have seen a number of cases
>> where sites had to increase the realpath cache size by quite a bit.
>
> Oh, and on top of that we also get a big performance improvement for
> include_path misses since we no longer have to re-stat every component
> of the docroot on every miss.
>
> -Rasmus