Re: [PATCH] No runtime fetching of built-in global constants

Hi Dmitry, Yeah, that looks good too, and should work the same way. :-) Thanks, Matt ----- Original Message ----- From: "Dmitry Stogov" Sent: Friday, August 29, 2008 > Hi Matt, > > I updated your patch a little bit to make it more clear (from my point > of view). > Please take a look. > > Thanks. Dmitry. > > Matt Wilmas wrote: > > Hi Dmitry, > > > > Well, it's been awhile since Alpha 1 :-), so I wanted to finally resend this > > before Alpha 2! I agree that the additional optimization probably wouldn't > > happen often, as there won't be that much namespace usage right away, I > > assume. But I think it makes sense to handle :: prefix constants, since > > they're known to have global scope, and I can see the future [online] > > optimization tip: "When using namespaces, use :: for global constants to get > > compile-time substitution." ;-) > > > > The code is the same as before, just updated the patch. It doesn't really > > seem less clear, to me, than the current code. In zend_do_fetch_constant(), > > the "check_namespace" variable may be better named something like > > "from_namespace" according to my changes, to be more clear, but I left that > > out to make the patch as simple as possible. > > > > http://realplain.com/php/ct_const_fixes.diff > > http://realplain.com/php/ct_const_fixes_5_3.diff > > > > > > Thanks, > > Matt