Re: [PATCH] No runtime fetching of built-in global constants
| From: | Matt Wilmas | Date: | Fri, 29 Aug 2008 10:14:20 +0000 |
| Subject: | Re: [PATCH] No runtime fetching of built-in global constants | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-40129@lists.php.net to get a copy of this message | ||
Hi Dmitry,
----- Original Message -----
From: "Dmitry Stogov"
Sent: Friday, August 29, 2008
> Ok, I'm going to commit it.
> Could you remember why we disabled constants substitution for ZEND_CT?
Yeah, it's to make sure something like -CONST in ZEND_CT context doesn't
work sometimes, sometimes not. My previous message (first part):
http://marc.info/?l=php-internals&m=121750618525882&w=2
> Thanks. Dmitry.
>
> Matt Wilmas wrote:
> > Hi Dmitry,
> >
> > Yeah, that looks good too, and should work the same way. :-)
> >
> >
> > Thanks,
> > Matt
> >
> >
> > ----- Original Message -----
> > From: "Dmitry Stogov"
> > Sent: Friday, August 29, 2008
> >
> >> Hi Matt,
> >>
> >> I updated your patch a little bit to make it more clear (from my point
> >> of view).
> >> Please take a look.
> >>
> >> Thanks. Dmitry.