Re: __getStatic
| From: | Lukas Kahwe Smith | Date: | Wed, 01 Oct 2008 07:52:36 +0000 |
| Subject: | Re: __getStatic | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-40815@lists.php.net to get a copy of this message | ||
On 08.09.2008, at 11:23, Timm Friebe wrote:
Hi, [...__(set|get|unset|isset)static()...]Can someone review this patch? regards, Lukas Kahwe Smith mls@pooteeweet.orgI've updated the patch and added some tests with it. http://sitten-polizei.de/php/getstatic.diff This requires a zend_vm_gen.php as I needed a new opcode (ZEND_ASSIGN_CLASS, 137). Please review this patch carefully, especially the part in zend_vm_def.h, I'm not sure this is correct.Patch looks pretty good. Plaease add __issetStatic and __unsetStatic. Then provide tests and submit to HEAD. For 5.3 Lukas and Johannes have to agree but I am sure they first want to see it in HEAD.Hope we havent missed any other we need to make this stuff complete .. But here is the blessing of the two RM's to have this committed before the alpha2 release ..