Re: str_getcsv

Hello, 2008/10/20 Lukas Kahwe Smith <mls@pooteeweet.org>: > > On 20.10.2008, at 23:07, Ilia Alshanetsky wrote: > >> >> On 20-Oct-08, at 4:46 PM, Hannes Magnusson wrote: >> >>> On Mon, Oct 20, 2008 at 22:43, Steve Hanselman <SteveH@brendata.co.uk> >>> wrote: >>>> >>>> Can anybody suggest a reason why this has never moved from main to >>>> php_5_2 or php_5_3? >>> >>> I did wonder the same months ago, but noone seemed to care, and I had >>> no use for it myself so I never bothered merging it :) >> >> The functionality is rather handy (I think), I would +1 for its addition >> to the 5.3 branch. > > > if someone commits it before alpha3 its fine by me. > Done! I've added a test and it's failing in HEAD though. We need check it, and to see what's the real behavior expected. A notable difference between the HEAD and 5.x fgetcsv implementation, is that in HEAD the delimiter, enclosure and escape can have more than 1 char. Then the following is valid: // string input[, string delimiter[, string enclosure[, string escape]]] var_dump(str_getcsv('<>foo++<><>[]<>bar<>', '[]', '<>', '++')); Should we really accept that? -- Regards, Felipe Pena.