Re: zend_call_method() - support for up to 4 parameters

Hello Nathan, Wednesday, February 18, 2009, 3:31:56 PM, you wrote: > On Wed, Feb 18, 2009 at 6:16 AM, Johannes Schlüter <johannes@php.net> wrote: >> But I don't think that a new limitation is any better: Tomorrow we have >> to change it again as somebody has a reason to use 5 parameters, so if >> it is changed it should be changed to take any number of arguments and >> no fixed limit.... (or add a new API for that) > that does seem ideal to me, but in the last thread, marcus was clear that an > emalloc / va_list solution was unacceptable. that was last january.. has > anything changed in that regard since? No. > also, it sounded like he was saying a simple solution for up to 4 parameters > would be alright. mainly i thought it would be nice to get it into the code > for 5.3 before we'd have to wait for another major release in order to get > something included. Stuff like this can imo always be added and whether you do #if PHP_VERSION_ID >= 50300 or #if PHP_VERSION_ID >= 50301 imo doesn't matter much. > yes, perhaps the function would need updating again in the future, but since > people are using macros rather than zend_call_method directly it wouldnt be > too bad right? No. I think if you have a reasonable need for 4 paramters, then that's good enough. On the other hand you shouldn't argue with me about 4 params :-) > -nathan Best regards, Marcus