Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

From:	Matt Wilmas	Date:	Thu, 19 Mar 2009 02:15:52 +0000
Subject:	Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int
References:	1 2 3 4	Groups:	php.internals
Request:	Send a blank email to internals+get-43397@lists.php.net to get a copy of this message

Hi again Dmitry, Just wanted to say that I think I can make your code a bit smaller after looking at it closer. Don't quite have enough time to modify and verify it now, but I'll be back later (around the usual time) to let you know either way. :-) - Matt ----- Original Message ----- From: "Dmitry Stogov" Sent: Wednesday, March 18, 2009

Hi Matt, I suppose I fixed the patch. Could you please check which patch is better yours or the attached one? According to attached benchmark my one is faster for most usual cases, but may be I forget something again. $a["abcdefghij"] 0.130 0.130 $a["1234567890"] 0.187 0.104 $a["2147483648"] 0.168 0.142
$a["0"]            0.116 0.082
$a["214748364x"] 0.136 0.141
$a[0]              0.080 0.080
Also, do you have other patches which I could look into before RC? Thanks. Dmitry.