Re: Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int
| From: | Matt Wilmas | Date: | Fri, 29 May 2009 21:00:48 +0000 |
| Subject: | Re: Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44094@lists.php.net to get a copy of this message | ||
Hi Rasmus,
----- Original Message -----
From: "Rasmus Lerdorf"
Sent: Thursday, March 19, 2009
So, what is the final conclusion on this one? Are we at a combination of Matt's and Dmitry's patches here? I think we definitely need to fix this even in the 5.2 branch and get it back to 5.1.x and earlier behavior. I consider it a bug that: $arr[3500000000] = 'blah'; print_r($arr); results in: [-2147483648] => blahI didn't think to ask at the time, but what do you think the result should be in your example...?
if someone has written brand new 5.2-specific code that relies on this weird behavior, then we will just have to bite the bullet and break that code. It is way more likely that people are relying on the earlier behavior and will end up with subtle problems in 5.2. I just had someone at Yahoo get bitten by this when they upgraded from 5.1.x to 5.2.x. -Rasmus- Matt