Re: Re: [PATCH] double to long conversion change
| From: | Dmitry Stogov | Date: | Wed, 22 Apr 2009 09:42:40 +0000 |
| Subject: | Re: Re: [PATCH] double to long conversion change | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43756@lists.php.net to get a copy of this message | ||
I looked into it some time ago.
Really, I don't understand what it's going to fix (the need of preserving low bits looks strange for me).
Also it breaks ~30 tests.
Thanks. Dmitry.
Johannes Schlüter wrote:
On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote:Hi Dmitry, I finally updated the patches: http://realplain.com/php/dval_to_lval.diff http://realplain.com/php/dval_to_lval_5_3.diffHas anybody (Dmitry?) reviewed this or other feedback? johannes