Re: set_magic_quotes_runtime is still E_DEPRECATED
| From: | Pierre Joye | Date: | Tue, 16 Jun 2009 08:09:43 +0000 |
| Subject: | Re: set_magic_quotes_runtime is still E_DEPRECATED | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44297@lists.php.net to get a copy of this message | ||
hi,
On Tue, Jun 16, 2009 at 9:46 AM, Lukas Kahwe Smith<mls@pooteeweet.org> wrote:
>
> On 16.06.2009, at 05:08, Greg Beaver wrote:
>
>> Hi,
>>
>> in PHP_5_3 if you're using set_magic_quotes_runtime(0), it raises an
>> E_DEPRECATED. I thought all that argument was resolved to only throw
>> E_DEPRECATED for set_magic_quotes_runtime(1)?
>>
>> This is a major pain if magic_quotes are enabled and you need to turn
>> them off to do unserialize or serialize to a file.
>
>
> The purpose of E_DEPRECATED is to alert of changes in up coming major PHP
> versions.
>
> So if the function is removed entirely from PHP6, then the way things are is
> correct. If the function still exists, but simply doesn't do anything (or
> even raises an error) when "set_magic_quotes_runtime(1)" is called, but
> silently continues when "set_magic_quotes_runtime(0)" is called, then it
> should be changed as per Greg's request.
The set_magic_quotes_runtime is removed in php6, not the getter. The
getter always returns FALSE without any notice or warning.
I think it makes sense to keep the deprecate warning for the setter.
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org