Re: Re: bug #48247 again
| From: | Lukas Kahwe Smith | Date: | Tue, 16 Jun 2009 08:21:29 +0000 |
| Subject: | Re: Re: bug #48247 again | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-44298@lists.php.net to get a copy of this message | ||
On 16.06.2009, at 10:07, Derick Rethans wrote:
On Thu, 11 Jun 2009, Stanislav Malyshev wrote:So lets delay fixing this issue until 5.3.1? Of course it can be fixed in HEAD right now :) regards, Lukas Kahwe Smith mls@pooteeweet.orgBug #48247 appears to be not entirely fixed still, it still produces a torrent of warnings in certain configs (namely, take php.ini-production and edit it to enable error_log, don't touch anything else - I get 400K worth of warnings). Attached patch should fix it. Please tell if there's some objection to it, otherwise I'll commit it tomorrow.The attached patch does fix one of the symtomps of the issue, but not the real problem. The real problem here is that from an error handler, another error is thrown. Instead of fixing this as a hack in any extension that has influence on formatting of error messages or error handling (through overriding the callback), a fix should be done in the error handling mechanism in order to prevent an error message generating another error message.