Re: studlyCaps patch
| From: | Andi Gutmans | Date: | Wed, 17 Sep 2003 04:07:40 +0000 |
| Subject: | Re: studlyCaps patch | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-4503@lists.php.net to get a copy of this message | ||
At 10:10 PM 9/16/2003 +0200, Marcus Börger wrote:
Hello Andi, Tuesday, September 16, 2003, 9:37:40 PM, you wrote: I think this patch is fine. I think (1) can be fixed quite easily. What do you mean when you say that (2) would result in a performance decrease? Would this only be in an error situation or also during regular runtime?Good idea. We can then see if it's worth it or not. AndiMy soulution to (2) required an additional estrndup() for all functions which are called by name. Maybe i should apply the parts done so far and send you the patch for (2), how about doing so?2) Errors for non existing functions are still shown lowercased. This could be changed too. But the performance decrease is higher so i wouldn't recommend that.