Re: Re: Fwd: Re: #25494 [Com]: array_merge allowing "false" as argument (silent when non-array is passed)
| From: | Jay Smith | Date: | Tue, 23 Sep 2003 17:42:47 +0000 |
| Subject: | Re: Re: Fwd: Re: #25494 [Com]: array_merge allowing "false" as argument (silent when non-array is passed) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-4557@lists.php.net to get a copy of this message | ||
Wez Furlong wrote:
>
> Actually, this is Ilia's decision, but I think we should not raise any
> notices for NULL values, for the sake of BC. It really does suck to break
> code that was working with no problems in a minor release.
>
> If the change had been made for 4.3, or 4.4 or 5, it wouldn't matter quite
> so much.
> But to change it for 4.3.4 !?
>
> --Wez.
Point taken. I've got no great attachment to the "fix", although I do prefer
the consistency with the other array functions.
Would checking for IS_ARRAY and IS_NULL be too much of a kludge?
J