Re: Re: Fwd: Re: #25494 [Com]: array_merge allowing "false" as argument (silent when non-array is passed)

I *love* it when threads silently die. ;-) Will this problem actually adressed by anyone or will we again have to release new versions of our software just because a minor PHP came out or deal with a huge amount of user complaints? Zitat von Jan Schneider <jan@horde.org>: > Zitat von Jay Smith <jay@php.net>: > > > Jan Schneider wrote: > > > > > > > > I generally agree (this is the purpose of E_NOTICE after all), but > > there > > > is a subtle difference between what has been fixed and what is broken > > now. > > > Passing NULLs to array_merge didn't lead to the borked arrays that > have > > > been "fixed" by this patch. > > > > > > > How are the arrays borked? The patch doesn't touch, skip or otherwise > do > > anything to any of the parameters, it just does a type check. Am I > > missing > > something here? (Which is quite possible...) > > Ah, well, I misread the original bug report. With "borked" I meant that > array_merge(false, array("foo" => "bar")) resulted in array(0 => > false, > "foo" => "bar"). I though this was changed by the patch. > > Anyway, array_merge(array("foo" => "bar"), null) was never producing > such > an > array and should thus not result in an E_NOTICE. Jan. -- http://www.horde.org - The Horde Project http://www.ammma.de - discover your knowledge http://www.tip4all.de - Deine private Tippgemeinschaft