Re: Re: Patch: Use notices in PDO

On 12.10.2009, at 12:07, Pierre Joye wrote:

hi, On Mon, Oct 12, 2009 at 11:58 AM, Matteo Beccati <php@beccati.com> wrote:

Given the recent posts, I'd vote to only add whatever is needed for the drivers to access the extra data. That means to only add the specific pgsql code to gather notices as the mysql and oracle drivers are already capable of fetching warnings/dbms_output. To me, this would be much clearer: a common interface to access different kind of data would definitely not be a step forward in terms of abstraction.

I'd to vote for nothing right now as I can't vote while shooting in the dark :) In other words I do think that this addition is a right step in terms of abstraction (and is mostly a debugging feature too). However as it has been said during this discussion we have to be careful. The only to be sure about the right way to do it is to have an implementation for each driver and valid it. A little RFC can help to keep tracks of everything. I like to go ahead with the implementation and then see if it is a good thing or not, or if it is possible at all for all drivers.

yeah .. it does seem like its trickier than i originally thought. moreover having a proper RFC will help document why we decided to add this feature (or not add), which can help for future similar discussion. the aim of the RFC is therefore to document the actual feature, the potential issues and the pro's and con's about having this inside PDO core. and of course links to proposed patches. regards, Lukas Kahwe Smith mls@pooteeweet.org