Re: Patch: Reflection Exception Messages
| From: | David Soria Parra | Date: | Sun, 28 Mar 2010 15:59:29 +0000 |
| Subject: | Re: Patch: Reflection Exception Messages | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47670@lists.php.net to get a copy of this message | ||
On 2010-03-28, Benjamin Eberlei <kontakt@beberlei.de> wrote:
> Index: ext/reflection/php_reflection.c
>===================================================================
> --- ext/reflection/php_reflection.c (revision 296963)
> +++ ext/reflection/php_reflection.c (working copy)
> @@ -3425,7 +3425,7 @@
> } else {
> efree(lc_name);
> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC,
> - "Method %s does not exist", name);
> + "Method %s::%s() does not exist", ce->name, name);
> return;
> }
> }
> @@ -3602,7 +3602,7 @@
> }
> }
> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC,
> - "Property %s does not exist", name);
> + "Property %s::%s does not exist", ce->name, name);
> }
> /* }}} *
>
> The patch is against SVN trunk.
looks good for me. if there are no objections from someone else I'll
commit it tomorrow.