Re: Re: Patch: Reflection Exception Messages
| From: | Lukas Kahwe Smith | Date: | Fri, 09 Apr 2010 07:26:32 +0000 |
| Subject: | Re: Re: Patch: Reflection Exception Messages | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47842@lists.php.net to get a copy of this message | ||
On 28.03.2010, at 17:59, David Soria Parra wrote:
> On 2010-03-28, Benjamin Eberlei <kontakt@beberlei.de> wrote:
>> Index: ext/reflection/php_reflection.c
>> ===================================================================
>> --- ext/reflection/php_reflection.c (revision 296963)
>> +++ ext/reflection/php_reflection.c (working copy)
>> @@ -3425,7 +3425,7 @@
>> } else {
>> efree(lc_name);
>> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC,
>> - "Method %s does not exist", name);
>> + "Method %s::%s() does not exist", ce->name, name);
>> return;
>> }
>> }
>> @@ -3602,7 +3602,7 @@
>> }
>> }
>> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC,
>> - "Property %s does not exist", name);
>> + "Property %s::%s does not exist", ce->name, name);
>> }
>> /* }}} *
>>
>> The patch is against SVN trunk.
>
> looks good for me. if there are no objections from someone else I'll
> commit it tomorrow.
@David: seems like you forgot to commit this?
regards,
Lukas Kahwe Smith
mls@pooteeweet.org