Re: ereg deprecation?

On 31.05.2010, at 19:23, Johannes Schlüter wrote: > On Mon, 2010-05-31 at 14:09 -0300, Felipe Pena wrote: >> Hi, >> >> 2010/4/28 Michael Maclean <michael@no-surprises.co.uk> >> >>> Hi, >>> I think I asked this before on IRC, but I've forgotten the answer. I was >>> just remembering that the ereg extension was due to be deprecated in PHP6 - >>> does this still apply to trunk? >>> >>> >> I think make no sense to keep it deprecated. >> >> Here's a patch for undeprecate ext/ereg in 5_3 and trunk: >> http://felipe.ath.cx/diff/undeprecate-ereg.diff >> >> Any objection? If no, I'll commit it in soon. > > I still won't recommend using ereg - the missing binary-safety causes > quite some broken checks ... is there anything that can be done which > can't be done using pcre? If not: Less code to maintain -> less > trouble :-) i would still keep it deprecated simply because people should not write new code with ereg, even if we do not have to remove it because of lack of unicode support. regards, Lukas Kahwe Smith mls@pooteeweet.org