Re: ereg deprecation?

2010/5/31 Felipe Pena <felipensp@gmail.com> > > 2010/5/31 Johannes Schlüter <johannes@schlueters.de> > > > On Mon, 2010-05-31 at 14:09 -0300, Felipe Pena wrote: > > > Hi, > > > > > > 2010/4/28 Michael Maclean <michael@no-surprises.co.uk> > > > > > > > Hi, > > > > I think I asked this before on IRC, but I've forgotten the answer. I > > was > > > > just remembering that the ereg extension was due to be deprecated in > > PHP6 - > > > > does this still apply to trunk? > > > > > > > > > > > I think make no sense to keep it deprecated. > > > > > > Here's a patch for undeprecate ext/ereg in 5_3 and trunk: > > > http://felipe.ath.cx/diff/undeprecate-ereg.diff > > > > > > Any objection? If no, I'll commit it in soon. > > > > I still won't recommend using ereg - the missing binary-safety causes > > quite some broken checks ... is there anything that can be done which > > can't be done using pcre? If not: Less code to maintain -> less > > trouble :-) > > > > > I also won't recommend using ereg, I just thought the unique reason to > deprecate it was the unicode stuff, hence wouldn't make sense to keep it > deprecated... But as there are others motivations, I prefer leave as is too. > > -- > Regards, > Felipe Pena Undeprecating the ereg extension now will not only cause confusion, because it has been deprecated for quite a while already, but it might also become a liability if Unicode or any similar non-compatible system might ever be included in the future. PCRE simply is faster under most conditions, more consistent and since a significant part of PHP Developers will also use Javascript, likely to be more appropriate for the web. Companies and individuals have been adjusting their scripts in favor of PCRE[1][2][3], undeprecating the extension seems senseless at this point. I do think Philip Olson's proposal of adding a compile-time flag for disabling ereg altogether is a good idea, as it would be the next step in moving ereg away from PHP's core. Regards, Peter Beverloo [1] https://drupal.org/node/530940 [2] http://bugs.typo3.org/view.php?id=9994 [3] http://www.mantisbt.org/bugs/view.php?id=10974