Re: [RFC] Array Dereferencing
| From: | Felipe Pena | Date: | Tue, 08 Jun 2010 00:14:23 +0000 |
| Subject: | Re: [RFC] Array Dereferencing | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-48678@lists.php.net to get a copy of this message | ||
2010/6/7 Stas Malyshev <smalyshev@sugarcrm.com>
> Hi!
>
>
> This is great. Did you check it on debug version though? I thought for
>> some reason you'd have to take care of freeing the value (which is
>> returned by function) after the expression is done, but maybe I missed
>> something. It's be also nice to see some more assignment tests (also
>> maybe return-array-by-ref test).
>>
>
> I checked it with debug and every case I could think of and it seems to be
> working just fine, so - commit it to trunk :)
>
>
Yes, I always use ZTS+Debug build :P
I have committed the patch and added new tests.
Thanks guys for the feedback.
--
Regards,
Felipe Pena