Re: Make primitive type names reserved words (Was: Re: [PHP-DEV] [RFC] 5.4 features for vote (long))
| From: | Felipe Pena | Date: | Sun, 10 Jul 2011 22:41:50 +0000 |
| Subject: | Re: Make primitive type names reserved words (Was: Re: [PHP-DEV] [RFC] 5.4 features for vote (long)) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53816@lists.php.net to get a copy of this message | ||
Hi,
2011/7/10 Nikita Popov <nikita.ppv@googlemail.com>:
> On Sun, Jul 10, 2011 at 11:37 PM, Lars Strojny <lars@strojny.net> wrote:
>>
>> Very good find of an inconsistency. Does the testsuite reveal something
>> strange with that patch?
>
>
> I didn't test that patch, just found it in the bugtracker.
> cellog@php.net would be a better person to ask, as he wrote it. But
> just from glancing at it I could imagine that it would break
> token_get_all() as CG(active_class_entry) wouldn't be set
> appropriately (though that's just a guess).
>
Yes, you are right. We cannot rely on CG(active_class_entry) data.
I'm against this patch, because we will just add more inconsistency.
Allow reserved words in method name, OK. But what about class
name/namespace name etc?
And in the begin of thread the topic was type name as class name,
nothing to do with methods.
--
Regards,
Felipe Pena