CRYPT_SHA256 fails tests in trunk
| From: | Solar Designer | Date: | Tue, 19 Jul 2011 23:44:06 +0000 |
| Subject: | CRYPT_SHA256 fails tests in trunk | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-54099@lists.php.net to get a copy of this message | ||
Hi,
These tests fail in trunk on my x86_64 build:
crypt_sha256.phpt
crypt_variation1.phpt
The differences are like this:
Expected: <$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5>
Got <$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNtQZWE2C3>
That is, the salts are truncated. There's a relevant recent change in
crypt.c involving the line:
salt_in_len = MIN(PHP_MAX_SALT_LEN, salt_in_len);
I did not investigate this for real - I am merely passing the info that
I readily have. I hope this helps.
Alexander