Re: CRYPT_SHA256 fails tests in trunk

hi, it seems that the changes break BC too, pls see https://bugs.php.net/bug.php?id=55477 Does that ring a bell to you? On Wed, Jul 20, 2011 at 1:44 AM, Solar Designer <solar@openwall.com> wrote: > Hi, > > These tests fail in trunk on my x86_64 build: > > crypt_sha256.phpt > crypt_variation1.phpt > > The differences are like this: > > Expected: <$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5> > Got       <$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNtQZWE2C3> > > That is, the salts are truncated.  There's a relevant recent change in > crypt.c involving the line: > >                salt_in_len = MIN(PHP_MAX_SALT_LEN, salt_in_len); > > I did not investigate this for real - I am merely passing the info that > I readily have.  I hope this helps. > > Alexander > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org