Re: PHP 5.3.8 Released!

From: Date: Wed, 24 Aug 2011 12:42:39 +0000
Subject: Re: PHP 5.3.8 Released!
References: 1 2 3 4 5 6 7 8 9 10 11 12  Groups: php.internals 
Request: Send a blank email to internals+get-54877@lists.php.net to get a copy of this message
Hi Alan, the breakage is about is_a with a string as 1st argument, not is_a as a whole. So yes, it breaks is_a alone is used as validation. On Wed, Aug 24, 2011 at 2:38 PM, alan@akbkhome.com <alan@akbkhome.com> wrote: > " If it's a clear bug, which IMHO this is_a() issue was - then unless we're > looking at code breakage at massive scale, it should be fixed. " > > mmh.. how much breakage did you want. > > PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like that > for > 8 years.... > > google search for PEAR::isError shows 16,600 matches.. > > > http://www.google.com/codesearch#search/&q=PEAR::isError%20lang:php&type=cs > > <http://www.google.com/codesearch#search/&q=PEAR::isError%20lang:php&type=cs> > > for is_a you get 149K. and this is only public code... > > It's big... Luckily quite a few people are on holiday this month and will > not upgrade too soon. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org

« previous php.internals (#54877) next »