Re: PHP 5.3.8 Released!
| From: | Stas Malyshev | Date: | Wed, 24 Aug 2011 21:10:10 +0000 |
| Subject: | Re: PHP 5.3.8 Released! | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-54893@lists.php.net to get a copy of this message | ||
Hi!
On 8/24/11 1:45 PM, Lester Caine wrote:
If I am reading things right, is_a was only designed to handle an object, so feeding it a mixed parameter in isError was always wrong? As far as I can see, on the whole, the PEAR code only ever feeds an object and feeding it a string would have to be a real error? So there are a number of actions here all of which are potentially wrong, and PEAR should return an error if $input is not a valid object rather than relying on undocumented actions simply to fail?If they just wanted to see if it's an object of class PEAR_Error, instanceof should be used. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227