Re: 5.4 beta & tests
| From: | Lonny Kapelushnik | Date: | Wed, 31 Aug 2011 06:52:32 +0000 |
| Subject: | Re: 5.4 beta & tests | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55028@lists.php.net to get a copy of this message | ||
>
> Test strtolower() function [ext/standard/tests/strings/strtolower.phpt]
> Test strtoupper() function [ext/standard/tests/strings/strtoupper1.phpt]
>
> I believe these fail on OSX because we test for undefined ASCII behavior.
We call strtolower/strtoupper for all 256 ASCII characters, but ASCII is
only defined for 128. The failure in these tests on OSX is above 128, which
I do not think we should be testing for.
I created a bug for the tests and added a patch to remove testing above 128
chars: https://bugs.php.net/bug.php?id=55546