Re: 5.4 beta & tests

Hi: I think you should not commit untill ask ilia for the reason of previous change, thanks 2011/8/31 Christian Stocker <christian.stocker@liip.ch>: > Hi > > Here's my proposed patch > https://gist.github.com/1183212 > > If noone objects, I'll commit it soon > > chregu > > On 31.08.11 11:39, Christian Stocker wrote: >> >> >> On 31.08.11 09:47, Stas Malyshev wrote: >>> Hi! >>> >>> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >>> Ilia reverted the fix for bug #48601 with this: >>> >>> >>> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 >>> >>> >>> I'm not sure what simplexml is supposed to return in each case, the >>> tests seem to be contradictory. Anybody knows what is the right thing to >>> do here? >> >> Ilia fixed test 0008.phpt with that, but for some reason an XPath of >> "***" isn't considered invalid by libxml (but "**" is, don't >> ask me why >> ;)). I'd say if libxml doesn't think the XPath expression is invalid, we >> should return an empty array and not false. With DOM exactly that happens. >> >> I therefore vote for reverting Ilia's patch mentioned above. >> >> chregu >> >> > > -- > Liip AG  //  Feldstrasse 133 //  CH-8004 Zurich > Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 > www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Laruence  Xinchen Hui http://www.laruence.com/