Re: [PATCH]#55651
| From: | Laruence | Date: | Sun, 11 Sep 2011 03:59:21 +0000 |
| Subject: | Re: [PATCH]#55651 | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55356@lists.php.net to get a copy of this message | ||
Hi:
after a quick look, I have one suggestion,
if the (Z_TYPE_P(z_value) != IS_BOOL), you should call
convert_to_boolean_ex to convert it to a boolean
otherwise, people can not use a interge 1 as a true flag.
thanks
2011/9/11 Avi Brender <abrender@elitehosts.com>:
> Hi,
>
> I've submitted bug #55651 along with a patch to implement a fix (also
> attached) for the passive FTP mode issue. I was hoping that someone could
> review the bug report and consider the patch for inclusion in future PHP
> releases.
>
> Thanks so much!
>
> Avi Brender
> Elite Hosts, Inc
> www.elitehosts.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Laruence Xinchen Hui
http://www.laruence.com/