Re: [PATCH]#55651

hi, A simple test if it is IS_BOOL or IS_LONG should be enough, both types use the the long value (convert_to_boolean_ex is slow and duplicate the zval while it is not necessary). Then test > 0 instead of simply assigning the value. On Sun, Sep 11, 2011 at 5:59 AM, Laruence <laruence@php.net> wrote: > Hi: >    after a quick look,  I have one suggestion, >    if the (Z_TYPE_P(z_value) != IS_BOOL), you should call > convert_to_boolean_ex to convert it to a boolean >    otherwise, people can not use a interge 1 as a true flag. > >    thanks > > 2011/9/11 Avi Brender <abrender@elitehosts.com>: >> Hi, >> >> I've submitted bug #55651 along with a patch to implement a fix (also >> attached) for the passive FTP mode issue. I was hoping that someone could >> review the bug report and consider the patch for inclusion in future PHP >> releases. >> >> Thanks so much! >> >> Avi Brender >> Elite Hosts, Inc >> www.elitehosts.com >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Laruence  Xinchen Hui > http://www.laruence.com/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org