Re: Revert Tokenizer behavior for 5.4
| From: | Nikita Popov | Date: | Tue, 13 Sep 2011 19:25:49 +0000 |
| Subject: | Re: Revert Tokenizer behavior for 5.4 | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55414@lists.php.net to get a copy of this message | ||
I changed my previous patch to an SVN patch, so it is easier to apply
and added another patch (the one called "tokenizer_patch_full.txt"),
which additionally fetches the rest into a T_INLINE_HTML. (The "_full"
patch thus contains both changes. I didn't know how I could separate
them.)
Could somebody apply the patch or give me advice how to improve it, so
it can be applied?
Thanks.
On Tue, Sep 13, 2011 at 9:57 AM, Nicolas Grekas
<nicolas.grekas+php@gmail.com> wrote:
>
>> I just set up an PHP environment and wrote a proper patch (including test
>> changes) to make it collect the next three tokens. It's a git patch and I'm
>> not sure whether it's compatible with SVN patches. I would love it if this
>> would go into 5.4 before beta. I didn't know how one could fetch the rest
>> into T_INLINE_HTML, so I'm hoping on help here from someone who actually
>> knowns C there :)
>
> I just reopened the bug and posted an excerpt of this discussion with your
> patch :
>
> https://bugs.php.net/bug.php?id=54089
>
> Nicolas
>