Re: Revert Tokenizer behavior for 5.4
| From: | Ferenc Kovacs | Date: | Tue, 13 Sep 2011 20:08:13 +0000 |
| Subject: | Re: Revert Tokenizer behavior for 5.4 | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55416@lists.php.net to get a copy of this message | ||
On Tue, Sep 13, 2011 at 9:56 PM, Christopher Jones
<christopher.jones@oracle.com> wrote:
>
>
> On 09/13/2011 12:25 PM, Nikita Popov wrote:
>>
>> I changed my previous patch to an SVN patch, so it is easier to apply
>> and added another patch (the one called "tokenizer_patch_full.txt"),
>> which additionally fetches the rest into a T_INLINE_HTML. (The "_full"
>> patch thus contains both changes. I didn't know how I could separate
>> them.)
>
> I haven't seen much "buy-in" about your email. You might want to wait
> until after Beta and revisit the topic later. If you add some concise
> explanation it would be easier for people to weigh the pros and cons,
> see what breaks and what gets fixed etc.
I agree that the lack of response is kind of disturbing:
no response in the bugreport, no response on the mailing list, almost
zero comment on irc. :/
I can accept that if it won't make into 5.3, or even 5.4.0, but at
least it could be merged to trunk, if the patch is fine.
I think that Nicolas and Nikita did more than enough on their part,
could somebody please review the patch?
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu