Re: Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue

All of the existing tests run. I will make one change as per C. Jones request to use a const for the hard coded 1024 window (since it's used twice). Also, I am unable to run the php-tests.php with the -m (valgrind) on my mac, so I'll need to run those on linux before I commit. In the mean time, I'll request an account. Thanks! Ralph On 11/10/11 1:51 PM, Rasmus Lerdorf wrote:

On 11/10/2011 11:44 AM, Ralph Schindler wrote:

Hey all, I've spent a bunch of time tracking down this issue (which was intermittent at best) and have identified the problem and have a patch for the solution. Details here: https://bugs.php.net/bug.php?id=60164 The attached patch is against trunk, PHP_5_4,& PHP_5_3. Seeing as though I've supplied patches in the past (see release notes), that I've spend significant time on understanding the Phar extension, and am able to fix issues there now, I'd like to be the one to commit this patch if internals is in agreement. So, how about it?

Go for it. I assume the patch doesn't break any existing tests? -Rasmus