Re: Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue
| From: | Rasmus Lerdorf | Date: | Thu, 10 Nov 2011 19:51:58 +0000 |
| Subject: | Re: Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-56247@lists.php.net to get a copy of this message | ||
On 11/10/2011 11:44 AM, Ralph Schindler wrote:
> Hey all,
>
> I've spent a bunch of time tracking down this issue (which was
> intermittent at best) and have identified the problem and have a patch
> for the solution.
>
> Details here: https://bugs.php.net/bug.php?id=60164
>
> The attached patch is against trunk, PHP_5_4, & PHP_5_3.
>
> Seeing as though I've supplied patches in the past (see release notes),
> that I've spend significant time on understanding the Phar extension,
> and am able to fix issues there now, I'd like to be the one to commit
> this patch if internals is in agreement.
>
> So, how about it?
Go for it. I assume the patch doesn't break any existing tests?
-Rasmus