Re: Re: libidn2 extension for php
| From: | Gustavo Lopes | Date: | Mon, 21 Nov 2011 12:44:34 +0000 |
| Subject: | Re: Re: libidn2 extension for php | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-56461@lists.php.net to get a copy of this message | ||
Em Mon, 21 Nov 2011 12:42:08 -0000, Hannes Magnusson <hannes.magnusson@gmail.com> escreveu:
On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs <tyra3l@gmail.com> wrote:Both options would preserve BC. I still haven't run or create new tests, but rest assured I will.* Add a second new parameter, by reference, wherein this extra information is written. * Instead of returning a string, return an array with all the new information.From what I can understand, if we go with option 1, then this patch would preserve BC, as it would only introduce additional arguments for the existing method. Did you checked that the tests are still passing with this patch? Could you also create a couple of tests covering the new behavior?
..And it bumps the minimal required ICU dependency, right?Yes. Obviously, this must be ifdef'd (and already is in the patch). -- Gustavo Lopes